Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
multiple reviewers bug
06-03-2011, 06:12 AM, (This post was last modified: 06-03-2011, 06:14 AM by broebel.)
#1
multiple reviewers bug
I'm playing with letoDMS and I really like it sofar!

I found one little issue with multiple reviewers. It is 100% reproducible.
Platform is WAMP.
LetoDMS v 3.0.0 downloaded yesterday.

log in as admin, then:

1) create a new group
2) add admin to this group
3) create user test1 and add to group
4) create user test2 and add to group
5) create a new folder
6) upload a new document
7) assign test1 and test2 as reviewers
8) log in as test1
9) click on newly added document

observe that both reviewers feature an active 'submit review' link, whereas only the one for test1 should be active.
Reply
06-06-2011, 03:17 PM,
#2
RE: multiple reviewers bug
Hy

try this:

Change in out/out.ViewDocument.php file, line 270
PHP Code:
if ($is_reviewer && $status["status"]==S_DRAFT_REV) { 

PHP Code:
if (($required==$user)&&$is_reviewer && $status["status"]==S_DRAFT_REV) { 


doudoux
Reply
06-06-2011, 07:39 PM,
#3
RE: multiple reviewers bug
(06-06-2011, 03:17 PM)Doudoux Wrote: Hy

try this:

Change in out/out.ViewDocument.php file, line 270
PHP Code:
if ($is_reviewer && $status["status"]==S_DRAFT_REV) { 

PHP Code:
if (($required==$user)&&$is_reviewer && $status["status"]==S_DRAFT_REV) { 


doudoux

Will this modification be in NEW DMS version?
"Whatever you do, work at it with all your heart, as working for the Lord, not for human masters". Kol.3:23
Reply
06-06-2011, 09:10 PM,
#4
RE: multiple reviewers bug
Hi

Once the correction is confirmed by the development team, it should be included in a future version of letoDMS.

doudoux
Reply
06-06-2011, 11:55 PM,
#5
RE: multiple reviewers bug
(06-06-2011, 03:17 PM)Doudoux Wrote: Hy

try this:

Change in out/out.ViewDocument.php file, line 270
PHP Code:
if ($is_reviewer && $status["status"]==S_DRAFT_REV) { 

PHP Code:
if (($required==$user)&&$is_reviewer && $status["status"]==S_DRAFT_REV) { 


doudoux

Thank you.
I modified the code according to your suggestion and it seems to fix the problem.
Reply
07-21-2011, 12:06 AM,
#6
RE: multiple reviewers bug
(06-06-2011, 09:10 PM)Doudoux Wrote: Hi

Once the correction is confirmed by the development team, it should be included in a future version of letoDMS.

doudoux

I just added it to the svn. The next stable release will have it.

Uwe
Reply
02-08-2012, 10:23 AM,
#7
RE: multiple reviewers bug
Hi

this work for one use reviewer, but dont work for a group reviewer.

For grouop reviewer dont allow put review
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)

Contact Us | LetoDMS Community Forum | Return to Top | | Lite (Archive) Mode | RSS Syndication